Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more uniformity tests #3269

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add more uniformity tests #3269

merged 2 commits into from
Jan 16, 2024

Conversation

alan-baker
Copy link
Contributor

Fixes #3266

  • Add tests covering lhs * and & expressions
  • Add tests requiring pointer_composite_access language feature

Issue: #

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker
Add more uniformity tests
d2a73f4 
Fixes gpuweb#3266

* Add tests covering lhs * and & expressions
* Add tests requiring `pointer_composite_access` language feature
zoddicus
zoddicus reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@zoddicus zoddicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a CTS writing perspective. I would like James review for content before submitting.

jrprice
jrprice approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@jrprice jrprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good set of additional test coverage, thanks!

Just one comment.

This also fixes #3226.

src/webgpu/shader/validation/uniformity/uniformity.spec.ts
check: `contents`,
uniform: false,
needs_deref_sugar: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These last two cases look identical? Maybe the first was meant to be a uniform case?

@alan-baker alan-baker merged commit 9874613 into gpuweb:main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoddicus zoddicus zoddicus left review comments

@jrprice jrprice jrprice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CTS
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve uniformity analysis coverage for nested LValue expressions
3 participants
@alan-baker @jrprice @zoddicus